maven icon indicating copy to clipboard operation
maven copied to clipboard

tests(maven#10389): Adding DefaultDependencyResolverResultTest

Open vijaykriishna opened this issue 1 month ago • 4 comments

Title: [https://github.com/apache/maven/issues/10389] tests(maven#10389): Adding DefaultDependencyResolverResultTest

Added unit tests for DefaultDependencyResolverResult Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Your pull request should address just one issue, without pulling in other changes.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.
  • [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • [x] Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

vijaykriishna avatar Nov 08 '25 00:11 vijaykriishna

Using DefaultType will remove 150 lines of code and will make the test more readable.

Done.

vijaykriishna avatar Nov 19 '25 00:11 vijaykriishna

Use a method or constants instead of those long calls to the constructors.

Came up with a reusable method.

vijaykriishna avatar Nov 27 '25 06:11 vijaykriishna

Please fix the formatting.

gnodet avatar Dec 02 '25 09:12 gnodet

Please fix the formatting.

oops missed it. Noted. Formatted the code using mvn spotless:apply.

vijaykriishna avatar Dec 02 '25 13:12 vijaykriishna