maven icon indicating copy to clipboard operation
maven copied to clipboard

[MNG-8748] org.apache.maven.api.services.model.UrlNormalizer should be a concrete class

Open jira-importer opened this issue 7 months ago • 3 comments

Elliotte Rusty Harold opened MNG-8748 and commented

There's only one implementation and unlikely to be others. This class should likely be final. It can be made non-final later if ever a need is uncovered to change the behavior.


No further details from MNG-8748

jira-importer avatar May 25 '25 10:05 jira-importer

Guillaume Nodet commented

Same comment as MNG-8749. This actually applies to the whole package imho.

jira-importer avatar May 27 '25 22:05 jira-importer

Elliotte Rusty Harold commented

Yes, agreed. I was noticing this one class at a time. However right now I only see one case where the relevant method is used in more than one class, and even there it's still just a single implementation function that can easily be static.

jira-importer avatar May 28 '25 12:05 jira-importer

Is this issue scoped to handle only UrlNormalizer or org.apache.maven.api.services.model package as agreed by others ? If the issue is unassigned as of today, please assign it to me. Happy to contribute.

vijaykriishna avatar Nov 08 '25 03:11 vijaykriishna