[SUREFIRE-2172] StringUtils: yet more of them

[FredrikAnderson]

Following this checklist to help us incorporate your contribution quickly and easily:

• [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
• [x] Each commit in the pull request should have a meaningful subject line and body.
• [x] Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles, where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
• [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• [x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• [x] You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

• [x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• [ ] In any other case, please file an Apache Individual Contributor License Agreement.

[FredrikAnderson]

Removed usage of StringUtils from:

• Apache Commons Lang StringUtils
• Surefire API StringUtils

Now only using Surefire Shared StringUtils. Is this enough for this ticket or are we aiming for something else?

[michael-o]

Can any dependency be removed?

[FredrikAnderson]

Can any dependency be removed?

No. apache commons-lang3 still used in module, surefire-its. StringUtils class still used alot in module surefire-api.

[elharo]

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

[michael-o]

@FredrikAnderson Care to complete this one?

[FredrikAnderson]

@FredrikAnderson Care to complete this one?

Yes. Tried by triggering a build

[michael-o]

@FredrikAnderson Can you check the failures please?

[FredrikAnderson]

Some artifact seems already uploaded and can't be again!? Seems more build environment related to me than cause specifically by this change. Don't know how to proceed here, I can't retrigger build. Please advice.

Error: With the provided path, there will be 7959 files uploaded Artifact name is valid! Root directory input is valid! Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

[michael-o]

What?

[FredrikAnderson]

Tried to resolve issues which has been commented and committed them. Guess someone need to approve the latest changes and PR? Futher the build fails for some unknown reason, which is what I commented before. Can't start retry/rebuild myself if that would work better now, so would need someone else to do that if you think that is a good option to try?

Only way I see I can take some action myself is to add an unneeded commit to trigger the build, which I would not prefer. Open for advice how to proceed with this PR.

[elharo]

Looks like it's simply failing to me:

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.apache.maven.surefire.its.JUnit47RedirectOutputIT.checkReports(JUnit47RedirectOutputIT.java:51)
	at 

Am I missing something?

[jira-importer]

Resolve #2751