maven-surefire icon indicating copy to clipboard operation
maven-surefire copied to clipboard

[SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe

Open liry opened this issue 3 years ago • 1 comments

Surefire is using surefire.failIfNoSpecifiedTests, but failsafe used it.failIfNoSpecifiedTests. Error msg is then pointed to nonexistent property: No tests matching pattern "..." were executed! (Set -Dfailsafe.failIfNoSpecifiedTests=false to ignore this error.)

Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles, where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

liry avatar Oct 11 '22 13:10 liry

Relates to https://issues.apache.org/jira/browse/SUREFIRE-1910, fixes https://issues.apache.org/jira/browse/SUREFIRE-2119. Not sure if the parameter deprecation can work this way.

liry avatar Oct 11 '22 13:10 liry