maven-surefire
maven-surefire copied to clipboard
[SUREFIRE-2041] Order test classes according to -Dtest property
This is a fix for SUREFIRE-2041.
It introduces a new "test" RunOrder which orders test classes according to the tests specified by -Dtest.
I have verified the implementation with both a unit test and an integration test.
Following this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles, where you replaceSUREFIRE-XXXwith the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run
mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (
mvn -Prun-its clean install).
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
-
[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
-
[ ] In any other case, please file an Apache Individual Contributor License Agreement.
@aslakhellesoy
I want to inform you about the plan. As you may have noticed, the current format of CSV values in -Dtest= have two forms:
- example with JUnit-ANT style: org/apache/**/domain/*/*FactoryTest (the extension .java is not a must)
- example: %regex[org.apache.*.domain.*FactoryTest]
These are file system based paths which makes the patterns irregular for Java users. These should turn to fully qualified names (FQN) of classes which is more natural for Java developers. Due to JUnit5 uses own description of test, FQN should not be considered as the only one pattern and more should be involved. This also means that the RunOrder feature is dependent on the refactoring where we break the backwards compatibility in this configuration parameter. Of course, we should agree on the format of these patterns in detail.