Backwards incompatibility in SvnCommandLineUtils introduced with 2.2.1

[kwin]

Affected version

2.2.1

Bug description

The commit SvnCommandLineUtils broke backwards compatibility as it removed the old method only taking two arguments. For example https://github.com/apache/maven-changelog-plugin is affected.

[kwin]

Probably time to introduce japicmp-maven-plugin to prevent his kind of issues in an automatic fashion.

[kwin]

@michael-o Any opinion on what should be considered API and what should probably be considered internal SCM use only?

[michael-o]

@michael-o Any opinion on what should be considered API and what should probably be considered internal SCM use only?

Will check next month

[michael-o]

I do not even know whether SvnCommandLineUtils are considered public API at all. Which method has been removed?

[kwin]

getBaseSvnCommandLine(…) now takes three arguments instead of two as before.

[michael-o]

This class really looks like an implementation detail because only the Maven SCM API is public. IMHO we are good to break it.

WDYT?

[kwin]

Can we use some annotations to mark certain APIs internal only? If so, which ones? I don't see anything suitable in https://github.com/apache/maven/tree/master/api/maven-api-annotations/src/main/java/org/apache/maven/api/annotations.

[michael-o]

We don't have them. Javadoc for the moment