maven-release icon indicating copy to clipboard operation
maven-release copied to clipboard

Published 20 hours ago • verified publisher icon apache

SSH option preparation

Open slavino opened this issue 3 years ago • 4 comments
trafficstars

preparing SSH support

Following this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles, where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

slavino avatar May 27 '22 16:05 slavino

I would recommend to collect all SSH private key related issues to one JIRA issue and create ONE PR for it.

michael-o avatar May 27 '22 17:05 michael-o

I don't have access to your JIRA so feel free.

The contribution isn't any rocket science at this stage but shouldn't break anything (backward compatibility shouldn't be affected). If needed then feel free to delete these PRs and create a new one.

Before announcing it as new feature it will need to be covered by proper tests. Afterwards it can also be mentioned in the official plugin documentation.

slavino avatar May 28 '22 15:05 slavino

JIRA is available to everyone: https://issues.apache.org/jira/projects/MRELEASE/issues/MRELEASE-1079?filter=allopenissues This are a bit harder because it will required to setup SSHd with MINA and test that.

michael-o avatar May 28 '22 15:05 michael-o

any update for this? We encounter a problem that the registered ssh private key is not used by the plugin.

scott-avery avatar Jun 08 '23 02:06 scott-avery