apache
Render a GitHub ribbon on all sites
firsst pass done for plugins only:
- #494
- #495
this PR is about extending to all projects, not only plugins
require introduction of property maven.site.gitHubProjectId for multi-module builds
Maybe it's a personal thing, but when I see a "fork me" ribbon/sign, I always get the feeling that this means "Hey this project is inactive, consider to fork it and work on yourself".
Why not but I think we had this in the past and remove it for some reasons Not sure why though and maybe I'm wrong 😀 @hboutemy do you remember something about this?
Maybe instead of ribbon we can add a right menu Get Sources or GitHub source/issues like on main site
pinting to GitHub - will be more clear that Fork Me ribbon
@kwin @olamy @Bukama after last comments I think to revert changes for GitHub ribbon for current release.
Make current 46 release without it and we can discuss it for next release
Why not but I think we had this in the past and remove it for some reasons Not sure why though and maybe I'm wrong 😀 @hboutemy do you remember something about this?
in the past, we wanted to promote ASF Gitbox and we wanted to avoid promoting a commercial solution: now that ship sank quite some time ago at ASF...
having a Ribbon on every released project site could help people, why not = what this PR ca do
for the 2 "non-released projects" sites = maven-site and Doxia-site, there is always to question about getting the (non-versioned) site sources vs discovering the vast list of sub-projects. This is a separate discussion to have, even if these 2 sites will benefit by default form a link to the site's GH
The next release introduces ribbons for plugins. That PR was back then approved by @olamy . Is there someone out there against this?
The next release introduces ribbons for plugins. That PR was back then approved by @olamy . Is there someone out there against this?
I'm not against, even more if we introduce it for plugins - and we agree the it is ok, I think that the rest project also can have an easy link to GitHub project
understanding now this PR given #494 and #495 have been merged is hard: working on description when creating a PR would really be appreciated, as title is definitively not sufficient
understanding now this PR given #494 and #495 have been merged is hard: working on description when creating a PR would really be appreciated, as title is definitively not sufficient
exactly - such #495 have been merged - we will have a GitHub ribbon for all plugins documentation ....
I would like to our sites will look the same (similar) independent of component type, so I propose this PR
before taking a decision, I tested #495 on a plugin: https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
given this is highly subjective, having a community discussion about activating it or not would (based on concrete example) make sense