maven-parent icon indicating copy to clipboard operation
maven-parent copied to clipboard

use `maven.compiler.release` instead of `.target`

Open bmarwell opened this issue 1 year ago • 15 comments

Change the properties as mentioned by Sylvester, so we have #224 for the actual Java 17 change

bmarwell avatar Feb 27 '24 21:02 bmarwell

Will redo this on maven-core first.

bmarwell avatar Feb 27 '24 21:02 bmarwell

this means all plugins will be 17 required. so all plugins upgrading to to this parent will not work for users of maven 3.x and jdk 8/11. sounds an issue to solve as it would mean eventually having branches for plugins in case of major bugs and/or security issues.

olamy avatar Feb 28 '24 05:02 olamy

We can not bump JDK in parent ... it will have an impact for all plugins ... but plugins should stay at JDK 8

plugins parent can have

    <javaVersion>8</javaVersion>
    <maven.compiler.source>${javaVersion}</maven.compiler.source>
    <maven.compiler.target>${javaVersion}</maven.compiler.target>

but anyway this need more residents as I guess some plugins will now maven4 API directly so there will be branches...

olamy avatar Feb 28 '24 09:02 olamy

can we split this PR to 2 - one to replace parameters to use .target - with the latest m-compiler-p it no longer requires special profile. That is only technical cleanup. And then dedicated - only to bump java to 17 as in vote?

slachiewicz avatar Apr 14 '24 07:04 slachiewicz

and can we avoid MNG issue for a change that is related to Maven parent POM?

hboutemy avatar Apr 14 '24 09:04 hboutemy

and can we avoid MNG issue for a change that is related to Maven parent POM?

Sure, both works for me. Will update soon.

bmarwell avatar Apr 14 '24 15:04 bmarwell

can we split this PR to 2 - one to replace parameters to use .target - with the latest m-compiler-p it no longer requires special profile. That is only technical cleanup.

What exactly are you thinking of?

// Edit: got it :)

bmarwell avatar Dec 30 '24 10:12 bmarwell

Do we want/need an issue? Merge now or later?

bmarwell avatar Dec 31 '24 08:12 bmarwell

I think that we need preserve also source and target - it will be used for jdk8

slawekjaranowski avatar Dec 31 '24 08:12 slawekjaranowski