maven-mvnd icon indicating copy to clipboard operation
maven-mvnd copied to clipboard

Published 20 hours ago • verified publisher icon apache

`JAVA_HOME` should be documented as discriminating

Open ppalaga opened this issue 2 years ago • 3 comments

I guess yes, at least for the sake of documenting it. I see that in DaemonCompatibilitySpec, it has a special position among the other discriminating options. But still, it is de facto discriminating, so we should put the discriminating flag on it. WDYT @gnodet ?

ppalaga avatar May 22 '23 12:05 ppalaga

I have added a commit to https://github.com/apache/maven-mvnd/pull/851 - so @gnodet please veto that one if needed.

ppalaga avatar May 22 '23 12:05 ppalaga

I have added a commit to #851 - so @gnodet please veto that one if needed.

I think it should be documented as discriminated, but it is handled specifically in a bunch of cases (as shown by the failings ITs), I think it may better to add some javadoc that will end-up in the help, wdyt ?

gnodet avatar May 22 '23 15:05 gnodet

it may better to add some javadoc that will end-up in the help

Good idea. Let me do it.

ppalaga avatar May 22 '23 17:05 ppalaga