maven-jlink-plugin icon indicating copy to clipboard operation
maven-jlink-plugin copied to clipboard

[MJLINK-85] Fix issue with single quoting every argument

Open matriv opened this issue 6 months ago • 0 comments

Each argument is first double quoted, but because of the default configuration of org.apache.maven.shared.utils.cli.shell.Shell is also single quoted on top. This leads to a shell command line which is not executable.

To fix this, leave the double quoting of each argument as it was, disable the single quoting of each argument with Shell configuration and wrap all the arguments as a whole string with single quotes, so that they are passed into bin/sh -c, example:

bin/sh -c '"--module-path" "foo:bar" "--add-modules" "mod1,mod2"'

Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [MJLINK-XXX] - Fixes bug in ApproximateQuantiles, where you replace MJLINK-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

matriv avatar Jul 31 '24 07:07 matriv