maven-javadoc-plugin icon indicating copy to clipboard operation
maven-javadoc-plugin copied to clipboard
verified publisher icon apache

[MJAVADOC-798] pass user settings to invoker

Open cpfeiffer opened this issue 1 year ago • 2 comments

Fixes MJAVADOC-798 to avoid dependency downloading problems due to ignoring user settings.

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.

  • [x] Each commit in the pull request should have a meaningful subject line and body.

  • [x] Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles, where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.

  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

  • [x] Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.

  • [x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004

  • [ ] In any other case, please file an Apache Individual Contributor License Agreement.

cpfeiffer avatar Jun 27 '24 07:06 cpfeiffer

I am a bit surprised why this never happened before...or no one else complained. Do you this you could create an IT. That would be most helpful.

michael-o avatar Jun 27 '24 09:06 michael-o

I was surprised as well. But I hadn't noticed invoker executions before either, so maybe that's the special case. Or our global settings.xml also managed find all dependencies.

Will have a look at integration tests.

cpfeiffer avatar Jun 27 '24 14:06 cpfeiffer

Merged, thanks. For the next PR please allow pushing to your fork.

michael-o avatar Jul 12 '24 19:07 michael-o

Thanks! I actually did have a look, but was unsuccessful in reproducing the issue in a maven-invoker IT. I will have another look when time permits and send another PR.

cpfeiffer avatar Jul 13 '24 06:07 cpfeiffer

Thanks! I actually did have a look, but was unsuccessful in reproducing the issue in a maven-invoker IT. I will have another look when time permits and send another PR.

Appreciated! It is a tricky one.

michael-o avatar Jul 13 '24 07:07 michael-o

Resolve #1174

jira-importer avatar Jun 10 '25 01:06 jira-importer