maven-deploy-plugin icon indicating copy to clipboard operation
maven-deploy-plugin copied to clipboard

[MDEPLOY-255] altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/c…

Open vtitov opened this issue 6 years ago • 2 comments
trafficstars

MDEPLOY-255 altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/cygwin on windows

Following this checklist to help us incorporate your contribution quickly and easily:

  • [x ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x ] Each commit in the pull request should have a meaningful subject line and body.
  • [ x] Format the pull request title like [MPH-XXX] - Fixes bug in ApproximateQuantiles, where you replace MPH-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [ x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [ ] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

vtitov avatar Apr 03 '19 18:04 vtitov

I consider this to be a workaround rather than a solution because the root cause has not been found.

michael-o avatar Apr 10 '19 22:04 michael-o

@michael-o, @eolivelli,

For me it is indeed w/a, which lets me modify, compile and deploy some stuff from github to internal repo to debug the project I'm working on. I consider it as a draft because I'm not sure it's me who have to decide if deploy plugin should get a couple (or three couples) of new parameters or there is another w/a. I suppose the problem might be related to org.apache.maven.shared.transfer.project.deploy.ProjectDeployerRequest from maven-artifact-transfer, but I considered as overkill for me to debug this project. he problem itself might be in incorrect storing/parsing colons and URL part of altDeploymentRepository parameter in mingw environment, because cygwin/mings might make attempts to convert unix/windows path separators:

  • ':'<->';'
  • '/'<->'\' When I pass repo id as text and url as URL plugin works fine. I'm not sure I'm ready for writing tests right now.

vtitov avatar Apr 18 '19 10:04 vtitov

Resolve #572

jira-importer avatar Apr 02 '25 07:04 jira-importer