Add / Improve tests for tree goal
The Tree goal lacks decent tests. This makes it hard to add new features without breaking stuff (see e.g. the discussion in #24). I decided to re-write tests for this goal by mocking away the components that the Tree goal uses.
The work is far from done. That's why there's no JIRA issue yet, and I deliberately did not check any of the licensing checkbox at the end of the checklist. Rather, I'd have a discussion whether this is the right approach for testing the goal. If so, I can continue the work in this direction. If all is done, we can do the administration (JIRA, agreement of Apache License, etc.).
- [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like
[MDEP-XXX] - Fixes bug in ApproximateQuantiles, where you replaceMDEP-XXXwith the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run
mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (
mvn -Prun-its clean verify).
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
-
[ ] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
-
[ ] In any other case, please file an Apache Individual Contributor License Agreement.