apache
Improve usage of silent parameter in Copy and Unpack goals
- parameter should be defined where is used, so move to child class from root class AbstractDependencyMojo
- use it during logging of coping or unpacking
@elharo @michael-o I know that you worked on silent parameter, and proposed to deprecate it.
It is directly used only in a few places so I propose move it to place where is used.
I alos remove overvriting logger in Mojo at all - it should be done by -q option.
I would like to have possibility to log what is copied, unpacked - form some of auditing perspective.
Using -X debug options is to verbose.
I do not want a large set of switches for every imaginable combination of logging this and that but not some other thing. The default is not to log things users don;t need to know and aren't going to act on the vast majority of the time. If you need more than that, turn on the debug logs. Yes, it's verbose but so is logging every file that's copied.
I do not want a large set of switches for every imaginable combination of logging this and that but not some other thing.
so I moved it where is used ... we have small number of switches
The default is not to log things users don;t need to know and aren't going to act on the vast majority of the time.
In this case I think it is useful information what happens
If you need more than that, turn on the debug logs. Yes, it's verbose but so is logging every file that's copied.
Similar we can say, if you don't want logs use -q options
@elharo changing log to system-out make be a problematic in Maven4
I don't understood why we can not use silent option where is needed .. eg is used in GoOfflineMojo
how do you want to replace such code:
https://github.com/apache/maven-dependency-plugin/blob/93776499fe324aa31c91c4ae9f0fb48878c8ab35/src/main/java/org/apache/maven/plugins/dependency/resolvers/GoOfflineMojo.java#L96-L104
Do we want to move every message into debug level?
Yes, exactly. Silent is debug, We don't need anything else. Our logs are vastly too noisy with severe consequences for usability.