Fix `CompilerMojo#getSourceInclusionScanner(String)` illogical `addAll`
Sonar identified that usage of addAll in CompilerMojo#getSourceInclusionScanner(String) was illogical - i.e. adding excludesIncr into itself:
https://github.com/apache/maven-compiler-plugin/blob/d79caa02f7b4b7efca14d178a1cc115ebf50e724/src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java#L394-L395
This was introduced in https://github.com/apache/maven-compiler-plugin/pull/141, and the same snippet is used in multiple places - only one has this defect, which I suspect is a copy-paste error.
Changes:
- updated to be consistent with the other examples
- removed the
this.qualifier, as the existingincrementalExcludesaccess in the same method doesn't use it to be consistent
I am not aware of any defect arising from this issue.
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like
[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles, where you replaceMCOMPILER-XXXwith the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run
mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (
mvn -Prun-its clean verify).
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
-
[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
-
[ ] In any other case, please file an Apache Individual Contributor License Agreement.