maven-assembly-plugin icon indicating copy to clipboard operation
maven-assembly-plugin copied to clipboard

[MASSEMBLY-607] Wildcard in dependencySet/includes doesn't match artifact with empty classifier

Open jira-importer opened this issue 13 years ago • 1 comments

Alexander Kormushin opened MASSEMBLY-607 and commented

Following dependency set will match only my jar artifacts with any non-empty classifier:

<dependencySet>
    <includes>
        <include>com.mycompany.*:*:jar:*:*</include>
    </includes>
</dependencySet>

But it seems wildcard should include empty ones.

Here is the related code fragment:

172    private boolean matchAgainst( final String value, final List patterns, final boolean regionMatch )

181            // fail immediately if pattern tokens outnumber tokens to match
182            boolean matched = ( patternTokens.length <= tokens.length );

I have following values achieving 182 line: pattern=[com.mycompany.*, *, jar, *, *] tokens=[com.mycompany, myproject, jar, 1.0.0-SNAPSHOT]


Affects: 2.3

Issue Links:

  • MSHARED-386 Wildcard does not work with null classifier ("depends upon")

jira-importer avatar May 11 '12 07:05 jira-importer