maven-assembly-plugin icon indicating copy to clipboard operation
maven-assembly-plugin copied to clipboard

[MASSEMBLY-852] - directoryMode permissions are lost if include is present

Open michaelboyles opened this issue 5 years ago • 0 comments

https://issues.apache.org/jira/browse/MASSEMBLY-852

The problem is essentially that ZipArchiver has 2 ways of setting directory mode ("override" and "default"), and we were only setting one of them. It is very unintuitive, but basically one is used when creating a directory outright (when a pattern matches it), and the other is used when creating the parent directories required by a matched file.

In the reporters case, the * ant pattern does not match the root directory so only the file is matched and the latter path is followed. There is a workaround to use a regex, which I posted on the ticket.

The safest thing for us to do is to set both the directory modes. We don't want to make a distinction between the two types.


Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles, where you replace MASSEMBLY-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

michaelboyles avatar Sep 23 '20 23:09 michaelboyles