maven-assembly-plugin icon indicating copy to clipboard operation
maven-assembly-plugin copied to clipboard

[MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

Open gnodet opened this issue 1 year ago • 2 comments

…requested ones.

JIRA issue: https://issues.apache.org/jira/browse/MASSEMBLY-791

gnodet avatar Jun 08 '23 03:06 gnodet

FYI, this pull request doesn't fixes original issue reported in MASSEMBLY-791, but fixes (with additional plugin configuration which is required to be added by the user of plugin (!)) a new issue introduced in 3.6.0 version and leading to the same (unexpected/invalid) behavior as described in MASSEMBLY-791. Refer to the comment in MASSEMBLY-989 for details. There is a big chance that with this pull request MASSEMBLY-791 can be closed as resolved.

Note that this pull request lacks test(s). One of the reasons behind that is that existing tests (located in the target branch of this pull request) fail when executed on Windows.

@gnodet and @elharo, I may need your help with tests, because it seems that I won't have time to work on this pull request till July 2023.

mabrarov avatar Jun 08 '23 20:06 mabrarov

Hi @elharo,

Regarding that comment:

  1. Integration test for the new configuration option was added.
  2. The case when invalid value is specified for overrideUmask plugin configuration option is described in Javadoc for org.apache.maven.plugins.assembly.mojos.AbstractAssemblyMojo#overrideUmask field. This Javadoc is used for generation of plugin documentation - plugin.xml - so I find it sufficient.

Thank you for your help with review of this pull request.

mabrarov avatar Jul 06 '23 19:07 mabrarov