maven-archetype
maven-archetype copied to clipboard
apache
[ARCHETYPE-584] fix indentation in root pom.xml
Problem: linebreaks + indentions (whitespaces) are read as actual document nodes. This causes problems in combination with
tr.setOutputProperty( OutputKeys.INDENT, "yes" );
tr.setOutputProperty( "{http://xml.apache.org/xslt}indent-amount", "2" );
Removed the .normalizeWhitespace() in tests, because this shadowed the actual bug. Also split one test into multiple tests. Test content remains the same.
Had to add the maven-4.0.0.xsd, not sure if this is desired.
@elharo is this ok now to merge, or do you think something additional is required?
can't merge, there are 4 ITs failing: https://builds.apache.org/blue/organizations/jenkins/maven-box%2Fmaven-archetype/detail/ARCHETYPE-584/14/pipeline :(
IT failures look real. I'm guessing that the golden data needs to be updated to match the output after this PR:
How does one update the golden data then ? This PR has gone stale but seems really only this last hurdle is missing.
Wow, this branch/bug is still around. I totally forgot about it.
After playing around with the integration tests a bit, one problem was to load the .xsd from the packaged .jar (which works differently from reading from a single file). Solving the loading from the jar seems to fix the ITs.
Let's see what comes up next or if this long journey reaches its happy end. :)
I committed a new attempt to get this merged. Since I do not understand which solution is acceptable, I made an unclean commit (code in comments, no proper exception handling). Would be nice to have some feedback, if this solution has any chance to get accepted before I clean it up.
I think so too and would love to try it out @kwin. Unfortunately maven-archetype-plugin version 3.3.0 is not released, yet.
Any estimated time when the release will happen? Or any way to test this, besides building the plugin locally?