MAHOUT-2096 [WIP] next() Called On Possible Empty iterator()

[balashashanka]

Purpose of PR:

Initially there was no check for the empty iterator when calling the next() function, which could result in an exception.

Important ToDos

Please mark each with an "x"

• [x] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
• [x] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
• [ ] Created unit tests where appropriate
• [ ] Added licenses correct on newly added files
• [ ] Assigned JIRA to self
• [ ] Added documentation in scala docs/java docs, and to website
• [x] Successfully built and ran all unit tests, verified that all tests pass locally.

If all of these things aren't complete, but you still feel it is appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"

Does this change break earlier versions? - No

Is this the beginning of a larger project for which a feature branch should be made? - Not sure

[rawkintrevo]

Thanks for the contribution @balashashanka !

lgtm- however,

1. We're in a code freeze at the moment as we're attmpeting to release 14.1 and only merging PRs relevant to release blockers
2. There was a moratorium on MR commits, however, I think we can allow this as I'm not sure that holds any more and also this is a maintenance patch.

Will discuss and (probably) merge after release.

[balashashanka]

Sure thanks.

[rawkintrevo]

@balashashanka my appologies for not following up sooner.

We're pivoting the project away from the Java/Scala big data focus to a python - quantum focus, would you be interested in being a maintainer on the java/scala stuff?

[rawkintrevo]

as it stands, this looks good to merge though

[balashashanka]

Thanks and yes I would be interested in taking the maintainer role, but would need some help in initial days though

Regards Shashanka Balakuntala Srinivasa

On Thu, 25 Jan 2024 at 9:39 PM, Trevor Grant @.***> wrote:

as it stands, this looks good to merge though

— Reply to this email directly, view it on GitHub https://github.com/apache/mahout/pull/401#issuecomment-1910521421, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCZIJX5PZU7EGYQXEKDJHLYQJ7TZAVCNFSM4OZY7FU2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJRGA2TEMJUGIYQ . You are receiving this because you were mentioned.Message ID: @.***>

[rawkintrevo]

are you on the [email protected] mailing list? we'd like to get you in to theasf slack channel (any chance you're already in there?)

[balashashanka]

I think I’m part of Asf slack channel (will double check and join) and will subscribe myself to dev@ mailing list.

On Fri, 26 Jan 2024 at 12:24 AM, Trevor Grant @.***> wrote:

are you on the @.*** mailing list? we'd like to get you in to theasf slack channel (any chance you're already in there?)

— Reply to this email directly, view it on GitHub https://github.com/apache/mahout/pull/401#issuecomment-1910800049, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCZIJX5IBWNOL2OXMYMOGTYQKS6TAVCNFSM4OZY7FU2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJRGA4DAMBQGQ4Q . You are receiving this because you were mentioned.Message ID: @.***>

[andrewmusselman]

@balashashanka I tagged you into the #mahout channel in the-asf slack, see you there!

[rawkintrevo]

i saw him come in- merging this now