lucene icon indicating copy to clipboard operation
lucene copied to clipboard

LUCENE-10612: Introduced Lucene93CodecParameters for Lucene93Codec

Open eliaporciani opened this issue 2 years ago • 1 comments

https://issues.apache.org/jira/browse/LUCENE-10612

Description

Lucene93Codec should provide a way for providing custom parameters to HnswVectorsFormat

Solution

For providing the various parameters to Lucene93Codec, I wrap them up in a Lucene93CodecParameters class. This should provide a cleaner and easier way to pass custom parameters.

#11648

eliaporciani avatar Jun 13 '22 13:06 eliaporciani

I'm not sure why this is easier or cleaner. To me it seems to create an unneccessary intermediate class, just for the purpose of passing parameters. Perhaps if we were trying to load parameters from a file or some other configuration storage, such a class might be useful. But then I think that class really belongs in the system that manages the properties or configuration, and can easily enough call these methods with the config class's members?

msokolov avatar Aug 07 '22 00:08 msokolov

Somewhat related to this newish issue (how to configure concurrent HNSW graph building).

Let's stick with the straightforward "pass args to ctor" for configuring Codec component writers?

mikemccand avatar Nov 02 '23 10:11 mikemccand