lucene icon indicating copy to clipboard operation
lucene copied to clipboard

LUCENE-9798 : Fix looping bug when calculating full KNN results in KnnGraphTester

Open nitirajrathore opened this issue 3 years ago • 2 comments

Description

There was a bug in the KNN Tester where in for large document vector files only first set of documents will be considered for Full Knn calculation

#10837

Solution

Fixed the bug and also made the code to execute parallelly, so as to take less time for large document vector files.

Tests

Created an abstraction to get ByteBuffers and used a simple wrapper over to test the core functionality. Created test cases for successful and exceptional cases.

Checklist

Please review the following and check all that apply:

  • [Check] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [Check ] I have created a Jira issue and added the issue ID to my pull request title.
  • [ Check] I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
  • [Check ] I have developed this patch against the main branch.
  • [ Check] I have run ./gradlew check.
  • [Check ] I have added tests for my changes.

nitirajrathore avatar Apr 14 '21 07:04 nitirajrathore

Fixed the bug and also made the code to execute parallelly, so as to take less time for large document vector files.

please, these need to be 2 separate issues.

rmuir avatar Apr 14 '21 12:04 rmuir

Fixed the bug and also made the code to execute parallely, so as to take less time for large document vector files.

please, these need to be 2 separate issues.

Sure @rmuir , I have reverted the changes for parallel execution from this PR. I will address that separately in a different PR and issue.

@msokolov : I will address issues related to parallel execution code in a separate PR.

nitirajrathore avatar Apr 20 '21 09:04 nitirajrathore

Thanks @nitirajrathore! This class has since moved to luceneutil I think? Do you know if this bug was resolved there? If not, could you maybe port this PR over to luceneutil? Thanks.

mikemccand avatar Nov 02 '23 11:11 mikemccand

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar Jan 09 '24 00:01 github-actions[bot]