LUCENE-10121: More skipping in WANDScorer.

[jpountz]

#11158

[jpountz]

I had to add a loop, which makes the patch bigger than it should be due to indentation changes. It's best to review the patch with ?w=1: https://github.com/apache/lucene/pull/319/files?w=1.

[jpountz]

I agree with you that this change is making the code harder to reason about. I'll look into ways to make the logic easier.

[gsmiller]

Thanks @jpountz. It might go a long way to just add some comments about the invariants that have to be maintained when updating the score, etc.

[jpountz]

Agreed. Maybe another way of fixing it would consist of preserving more significant bits in the scaled values. I'll look into that as well.

[mikemccand]

@jpountz is this still relevant? There have been lots of optos to WANDScorer lately... maybe this is already essentially done?

[jpountz]

It's still relevant but I'm not comfortable with the fact that it's a bit fragile. I'll close for now and think more about it.