lucene icon indicating copy to clipboard operation
lucene copied to clipboard

LUCENE-10059: Additional fix to handle n_best backtrace

Open jimczi opened this issue 4 years ago • 1 comments

This commit handles possible empty backtrace when using the nbest option. The general case (best path) was fixed in a previous commit so this change is a follow up to handle all cases.

jimczi avatar Sep 07 '21 13:09 jimczi

I'm sorry for the late reply, looks good to me, thanks @jimczi ! There are conflicts due to the recent refactoring #805, would you mind if I adjust this and merge to main?

Old parse() method in JapaneseTokenizer and KoreanTokenizer has been integrated into org.apache.lucene.analysis.morph.Viterbi.forward() in analysis-common module, so this change can be applied to it and we no longer need to maintain two parse() methods (in main).

mocobeta avatar May 08 '22 02:05 mocobeta

@jimczi -- is this still relevant? Thanks.

mikemccand avatar Nov 02 '23 10:11 mikemccand

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar Jan 09 '24 00:01 github-actions[bot]