lucene icon indicating copy to clipboard operation
lucene copied to clipboard

LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes

Open cpoerschke opened this issue 3 years ago • 4 comments

https://issues.apache.org/jira/browse/LUCENE-8638 and https://issues.apache.org/jira/browse/LUCENE-8682

#9728

cpoerschke avatar Jul 02 '21 18:07 cpoerschke

And I'd like to mention that https://github.com/apache/solr/search?q=WordDelimiterFilter currently still contains references and we may wish to deal with them before merging this pull request or perhaps afterwards?

cpoerschke avatar Jul 02 '21 18:07 cpoerschke

And I'd like to mention that https://github.com/apache/solr/search?q=WordDelimiterFilter currently still contains references and we may wish to deal with them before merging this pull request or perhaps afterwards?

Ah, there's already https://issues.apache.org/jira/browse/LUCENE-8682 with a patch which includes Solr.

cpoerschke avatar Jul 02 '21 18:07 cpoerschke

And I'd like to mention that https://github.com/apache/solr/search?q=WordDelimiterFilter currently still contains references and we may wish to deal with them before merging this pull request or perhaps afterwards?

Ah, there's already https://issues.apache.org/jira/browse/LUCENE-8682 with a patch which includes Solr.

https://github.com/apache/solr/pull/200 created with the LUCENE-8682 patch as its starting point.

cpoerschke avatar Jul 03 '21 11:07 cpoerschke

Thanks @msokolov for copying across the comments from the JIRA! I'll convert the pull request to "draft" to indicate the status of the deprecation process.

cpoerschke avatar Jul 10 '21 21:07 cpoerschke

but I don't think WordDelimiterGraphFilter is a full replacement for WordDelimiterFilter since it can't be used in conjunction with other filters that consume or produce graphs, like SynonymGraphFilter.

Yeah I'm pretty sure this is still the case, unfortunately. It's a hard problem.

mikemccand avatar Nov 02 '23 11:11 mikemccand