lucene icon indicating copy to clipboard operation
lucene copied to clipboard

factor out (public static) MultiCollector.scoreMode(Collector[]) method

Open cpoerschke opened this issue 1 year ago • 3 comments

To allow re-use rather than duplication of the logic e.g. see https://github.com/apache/solr/pull/2248/commits/3cee3e591995520cdfed41a5228a2e01c3b5cc0f#r1485486388 thread.

cpoerschke avatar Feb 21 '24 17:02 cpoerschke

I'm not too familiar with the Solr code but I see that it duplicates logic in setScorer as well, could it reuse MultiCollector directly instead of exposing the method that combines score modes?

jpountz avatar Feb 21 '24 18:02 jpountz

... could it reuse MultiCollector directly instead of exposing the method that combines score modes?

I'd wondered the same-ish i.e. MultiCollectorManager re-use -- https://github.com/apache/solr/pull/2248/files#r1489857592 -- but so far don't see a way, perhaps just needs more looking at and into. @chatman or @dsmiley might also have more context or thoughts on this?

cpoerschke avatar Feb 21 '24 18:02 cpoerschke

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar Mar 07 '24 00:03 github-actions[bot]