Remove one of SparseFixedBitSet/DocIdSetBuilder.Buffer [LUCENE-10443]

Open asfimport opened this issue 3 years ago • 1 comments

SparseFixedBItSet is no longer used by DocIdSetBuilder, but the class didn't get cleaned up and removed.

We only need one sparse representation and don't need to just litter up the codebase with unnecessary classes.

Migrated from LUCENE-10443 by Robert Muir (@rmuir)

Feb 25 '22 13:02 asfimport

SparseFixedBItSet is no longer used by DocIdSetBuilder, but the class didn't get cleaned up and removed.

In main branch, SparseFixedBItSet is used by UnicodeProps, Lucene90OnHeapHnswGraph and DocValuesFieldUpdates. There are more usages in test related code also. @rmuir Are you thinking to replace SparseFixedBItSet with DocIdSetBuilder.Buffer in the above classes ?

Sep 23 '22 17:09 shahrs87