lucene-solr icon indicating copy to clipboard operation
lucene-solr copied to clipboard

Published 20 hours ago • verified publisher icon apache

SOLR-14792: Remove VelocityResponseWriter

Open erikhatcher opened this issue 4 years ago • 4 comments

Description

Remove VelocityResponseWriter and its references and usages.

Solution

Removed contrib/velocity and all related uses.

Tests

Will ensured all Solr tests, precommit, and smoketesters pass.

Checklist

Please review the following and check all that apply:

  • [x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [x] I have created a Jira issue and added the issue ID to my pull request title.
  • [x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [x] I have developed this patch against the master branch.
  • [ ] I have run ./gradlew check.
  • [ ] I have added tests for my changes.
  • [x] I have adjusted documentation for the Ref Guide (for Solr changes only).

erikhatcher avatar Sep 04 '20 01:09 erikhatcher

@erikhatcher BTW, the .adoc format renders nicely in Github if you were to pull the ref guide docs over to https://github.com/erikhatcher/solritas. We could also update the link in the solr.cool entry to point directly to them, instead of the general github README page ;-)

epugh avatar Sep 04 '20 10:09 epugh

@erikhatcher BTW, the .adoc format renders nicely in Github if you were to pull the ref guide docs over to https://github.com/erikhatcher/solritas. We could also update the link in the solr.cool entry to point directly to them, instead of the general github README page ;-)

Thanks for that tip! I'll definitely be pulling the docs over and adjusting.

erikhatcher avatar Sep 04 '20 15:09 erikhatcher

BTW the more up do date https://github.com/erikhatcher/solritas is in the next few days, the better as I'll be doing a recorded Activate session on this September 10th with a demo of it.

dsmiley avatar Sep 04 '20 16:09 dsmiley

Reviewing leftover references: The /browse is still mentioned in the following files:

  • example/files/README.txt (actually that is broken even in released Solr)
  • solr/solr-ref-guide/src/solr-tutorial.adoc
  • solr/solr-ref-guide/src/initparams-in-solrconfig.adoc
  • solr/solr-ref-guide/src/rule-based-authorization-plugin.adoc

Looks ok otherwise, apart from accidentally check-ins.

arafalov avatar Sep 06 '20 01:09 arafalov