logging-log4j2 icon indicating copy to clipboard operation
logging-log4j2 copied to clipboard

Implements an event service and demonstrates its use for sending/receiving SSL key/trust store changes

Open MichaelMorrisEst opened this issue 1 year ago • 3 comments

Intended as a means to discuss what the implementation for https://github.com/apache/logging-log4j2/issues/3074#issuecomment-2446935514 should look like

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

MichaelMorrisEst avatar Jan 10 '25 14:01 MichaelMorrisEst

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 :white_check_mark: Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 :white_check_mark: Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 :white_check_mark: Build Scan PUBLISHED

Generated by gradle/develocity-actions

github-actions[bot] avatar Jan 14 '25 07:01 github-actions[bot]

The PR looks nice, but I need some time to analyze the existing code to see if we can reuse something. WatchManager looks reusable, but it works in a complex way.

ppkarwasz avatar Feb 11 '25 16:02 ppkarwasz

Instead of a fully-blown event bus that is publicly exposed, can we make this private and as small as possible, please? I agree with @ppkarwasz that we shall seek to use existing file watching mechanisms available, if possible.

vy avatar Feb 12 '25 09:02 vy

Hi @MichaelMorrisEst,

Since #2767 was merged instead, I think we can close this PR. Any objections?

ppkarwasz avatar Jun 26 '25 07:06 ppkarwasz

That's fine, not needed now we have #2767

MichaelMorrisEst avatar Jun 26 '25 18:06 MichaelMorrisEst