logging-log4j1
logging-log4j1 copied to clipboard
apache
Sprechender Name
Hello,
please close this one. In a workshop I help spontaniously we needed an example of a pull request and I used your repo.
Sorry for not taking back the pull request myself.
Kindest regards Sönke Gissel
Von: Manfred Huber [email protected] Gesendet: Donnerstag, 6. Februar 2020 10:02 An: apache/log4j [email protected] Cc: Gissel, Sönke [email protected]; Author [email protected] Betreff: Re: [apache/log4j] Sprechender Name (#11)
@downdrown commented on this pull request.
In src/main/java/org/apache/log4j/Logger.javahttps://github.com/apache/log4j/pull/11#discussion_r375709913:
@@ -54,15 +54,15 @@
*/
static
public
- Logger getLogger(String name) {
- Logger getLoggerID(String name) {
Whats wrong/irritating about #getLogger(String)? IMHO #getLoggerID(String) is much more misleading, since the return type of this method is a Logger, not an ID ...
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/apache/log4j/pull/11?email_source=notifications&email_token=ANLBURT75VBIHEWAUKUZKWDRBPG2JA5CNFSM4KEZE6Y2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUO72QY#pullrequestreview-354286915, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANLBURXTJWU25SCIBDCE4VTRBPG2JANCNFSM4KEZE6YQ.