FLUME-3347:Direct buffer memory causes sink thread to die

Open lightzhao opened this issue 6 years ago • 4 comments

When the java.lang.OutOfMemoryError: Direct buffer memory exception occurs in the hdfsSink thread, the exception is thrown to the SinkRunner thread, but the SinkRunner thread does not catch the Throwable exception, causing the hdfsSink thread to die。

Nov 19 '19 12:11 lightzhao

exception

Nov 19 '19 12:11 lightzhao

@mpercy Can you help me review?

Nov 20 '19 04:11 lightzhao

@bessbd can you please review?

Dec 07 '19 03:12 lightzhao

Thank you for the patch, @lightzhao !

The idea for this change sounds good. Unfortunately, without the right justification, this code probably should not be merged. Can you please think of an alternative improvement?

Dec 07 '19 10:12 bessbd