linkis icon indicating copy to clipboard operation
linkis copied to clipboard

[Refactor] refactor linkis-web module

Open legendtkl opened this issue 3 years ago • 3 comments

What is the purpose of the change

Refactor linkis-web

Related issues/PRs

Related issues: https://github.com/apache/incubator-linkis/issues/2702

Brief change log

minor change

legendtkl avatar Aug 11 '22 15:08 legendtkl

 <modules>
        <module>linkis-commons</module>
        <module>linkis-spring-cloud-services</module>
        <module>linkis-orchestrator</module>
        <module>linkis-public-enhancements</module>
        <module>linkis-computation-governance</module>
        <module>linkis-engineconn-plugins</module>
        <module>linkis-extensions</module>
        <module>web</module>
        <module>linkis-dist</module>
    </modules>

the parent pom.xml web should rename to linkis-web

casionone avatar Aug 12 '22 01:08 casionone

Hi, @casionone , I have addressed the review comment.

Would you help review again? thanks.

legendtkl avatar Aug 12 '22 06:08 legendtkl

Codecov Report

Merging #2714 (c69a362) into dev-1.3.0 (ea43a6d) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff              @@
##             dev-1.3.0    #2714   +/-   ##
============================================
  Coverage        14.76%   14.76%           
  Complexity        1166     1166           
============================================
  Files              740      740           
  Lines            23194    23194           
  Branches          3436     3436           
============================================
  Hits              3425     3425           
+ Misses           19305    19303    -2     
- Partials           464      466    +2     
Impacted Files Coverage Δ
...a/org/apache/linkis/scheduler/queue/Consumer.scala 85.71% <0.00%> (-14.29%) :arrow_down:
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 35.55% <0.00%> (-2.23%) :arrow_down:
...apache/linkis/scheduler/queue/LoopArrayQueue.scala 34.90% <0.00%> (+2.83%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 12 '22 07:08 codecov[bot]