libcloud icon indicating copy to clipboard operation
libcloud copied to clipboard
verified publisher icon apache

RcodeZero Driver: fix issue when adding a record where a record with a different type already exists

Open MikeAT opened this issue 11 months ago • 4 comments

RcodeZero: Bugfix when adding a record where a record with a different type already exists

Description

The RcodeZero driver generated broken API-Requests when adding records with different type (eg. adding an AAAA record to an existing A record). This PR fixes #2042:

Status

Done, ready for review

Checklist (tick everything that applies)

  • [X] Code linting (required, can be done after the PR checks)
  • [X] Documentation
  • [X] Tests
  • [ ] ICLA (required for bigger changes)

MikeAT avatar Jan 03 '25 10:01 MikeAT

Could you please merge this documentation PR too?

MikeAT avatar Jan 03 '25 11:01 MikeAT

@MikeAT Thanks for the contribution.

Would it be possible to add a unit test case for this fix?

Kami avatar Mar 02 '25 17:03 Kami

@MikeAT The documentation PR has been merged.

It looks like the existing tests are failing. It would be great if you could look into that (you likely need to add mock response fixtures for v2 API responses and implement corresponding methods on the MockHttp class) and add a (regression) test case for a bug this PR is fixing.

Thanks.

Kami avatar Mar 03 '25 07:03 Kami

Hi @Kami,

sorry, I forgot to commit the API v2 tests. And I added the regression test for the fixed bug.

MikeAT avatar Mar 03 '25 10:03 MikeAT