libcloud icon indicating copy to clipboard operation
libcloud copied to clipboard

Published 20 hours ago • verified publisher icon apache

chore: Deprecate facility in the favor of metro

Open aayushrangwala opened this issue 1 year ago • 7 comments

Changes Title (replace this with a logical title for your changes)

Deprecate facility in the favor of metro API

Description

  • Support Metros location in libcloud interfaces and deprecate facility api.
  • Also, remove implementation of storage APIs as they were removed from Packet years ago. there is no direct replacement. Equinix Metal offers Pure and NetApp storage devices today but there is not equivalent functionality as far as the Equinix Metal API is concerned with directly attaching storage to servers and equinix metal doesnot supports only 2 storage providers and

For more information on contributing, please see Contributing section of our documentation.

Status

Ready For Review

Checklist (tick everything that applies)

  • [x] Code linting (required, can be done after the PR checks)
  • [x] Documentation
  • [x] Tests
  • [x] ICLA (required for bigger changes)

aayushrangwala avatar Nov 09 '23 15:11 aayushrangwala

@aayushrangwala perhaps the removal of strorage should be done in a separate PR from the facility deprecation and introduction of metros.

displague avatar Nov 09 '23 17:11 displague

nice i"ll puul this PR into my work area and make sure PR #1970 & PR #1971 are all thats needed to tqeak EqunixMetal back into prime shape.

luss avatar Nov 10 '23 16:11 luss

Also, I agree with @displague that it's cleaner, safer, & simpler to keep each PR small & doing a specifc thing. That's why I started this journey to update the EquinixMetal driver with the simple and safe PR #1970

luss avatar Nov 10 '23 16:11 luss

@aayushrangwala perhaps the removal of strorage should be done in a separate PR from the facility deprecation and introduction of metros.

Sure, will raise another PR

aayushrangwala avatar Nov 12 '23 08:11 aayushrangwala

Reviewers, please note that Equinix Metal removed the facilities/facility request field in June for new users, and the field will be entirely unavailable for all users after December. metro is the replacement. Facilities reside within a metro. Legacy facility values are not compatible with the metro field.

https://feedback.equinixmetal.com/changelog/reminder-facilities-turns-to-metros-on-may-30

displague avatar Nov 13 '23 12:11 displague

@Kami Can you please review and approve this PR as well

aayushrangwala avatar Nov 21 '23 17:11 aayushrangwala

@aayushrangwala Looks like tests and some other CI checks are failing. Can you please look into it when you get a chance?

Thanks.

Kami avatar Dec 03 '23 10:12 Kami

Sorry for the delay - the PR has finally been merged into trunk.

Thanks again for your contribution.

Kami avatar Apr 18 '24 16:04 Kami