libcloud icon indicating copy to clipboard operation
libcloud copied to clipboard

Adjust parameters to GoDaddy get_zone method

Open Circuitsoft opened this issue 2 years ago • 2 comments

Other drivers take the ID, not the domain name. This puts the GoDaddy driver in-line with how other drivers work.

Changes Title (replace this with a logical title for your changes)

Description

Saltstack has been throwing errors when working with GoDaddy dns entries because the driver takes different parameters than other drivers it was designed around. This fixes the interface to put it more in-line with other drivers.

Status

done, ready for review

Checklist (tick everything that applies)

  • [ ] Code linting (required, can be done after the PR checks)
  • [ ] Documentation
  • [ ] Tests
  • [ ] ICLA (required for bigger changes)

Circuitsoft avatar Oct 24 '23 18:10 Circuitsoft

@Circuitsoft Thanks for the contribution.

Since this is a breaking change, can you please add an entry to docs/upgrade_notes.rst file? You should be able to find some examples on how to word an entry in that file.

Thanks.

Kami avatar Oct 28 '23 16:10 Kami

@Circuitsoft It appears tests are also failing.

 >        domain, = [x.domain for x in self.list_zones() if x.id == zone_id]
 E       ValueError: not enough values to unpack (expected 1, got 0)

Can you please also look into this when you get a chance? Thanks

Kami avatar Dec 03 '23 11:12 Kami