libcloud icon indicating copy to clipboard operation
libcloud copied to clipboard

Azure: Add the ability to use Ultra SSDs

Open jwk404 opened this issue 3 years ago • 2 comments

This change adds a function to update additional_capabilities so that Ultra SSDs can be added. Additional changes allow specific provisioned IOPS and throughput.

Azure: Add the ability to use Ultra SSDs

Description

To add UltraSSD disks in Azure, a flag must be toggled on the VM itself. Once the flag is enabled, a disk of this type may be provisioned with a specific cap on IOPS and throughput. This commit adds a function to toggle the compatibility flag, and adds the ability to specify IOPS and throughput numbers.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • [x] Code linting (required, can be done after the PR checks)
  • [ ] Documentation
  • [x] Tests
  • [ ] ICLA (required for bigger changes)

jwk404 avatar Aug 15 '22 19:08 jwk404

Thanks for the contribution.

I added a comment / question on the method return value, besides that, LGTM.

Kami avatar Sep 02 '22 19:09 Kami

Codecov Report

Merging #1744 (aba6641) into trunk (c2cd332) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1744      +/-   ##
==========================================
+ Coverage   83.37%   83.40%   +0.02%     
==========================================
  Files         400      392       -8     
  Lines       88009    87636     -373     
  Branches    10679    10611      -68     
==========================================
- Hits        73381    73096     -285     
+ Misses      11456    11383      -73     
+ Partials     3172     3157      -15     
Impacted Files Coverage Δ
libcloud/compute/drivers/azure_arm.py 58.38% <100.00%> (+0.56%) :arrow_up:
libcloud/test/compute/test_azure_arm.py 98.85% <100.00%> (+0.02%) :arrow_up:
libcloud/storage/__init__.py
libcloud/base.py
libcloud/compute/__init__.py
libcloud/pricing.py
libcloud/loadbalancer/__init__.py
libcloud/utils/__init__.py
libcloud/__init__.py
libcloud/storage/base.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2cd332...aba6641. Read the comment docs.

codecov-commenter avatar Sep 02 '22 19:09 codecov-commenter

I've fixed a small typo in docstring (c48b456af7dc243a6ccf00d53408f0494e961f79) and merged changes into trunk. Thanks!

Kami avatar Sep 25 '22 10:09 Kami