libcloud icon indicating copy to clipboard operation
libcloud copied to clipboard

Clean compute drivers

Open ZuluPro opened this issue 3 years ago • 2 comments

Removed obsolete compute drivers

Description

Remove:

  • [x] Bluebox
  • [x] bsnlcloud
  • [x] Cloudwatt
  • [x] enomaly
  • [x] elastichosts
  • [x] elasticstack
  • [x] Kili
  • [x] gogrid
  • [x] Gridspot
  • [x] hostvirtual (now netactuate)
  • [x] Joyent
  • [x] med-1
  • [x] nephoscale
  • [x] 1and1 (now IONOS)
  • [x] profitbricks (now IONOS)
  • [x] ServerLove
  • [x] skalicloud
  • [x] Softlayer (now IBM)
  • [x] Voxel

For more information on contributing, please see Contributing section of our documentation.

Status

Done

Checklist (tick everything that applies)

  • [x] Code linting (required, can be done after the PR checks)
  • [x] Documentation
  • [x] Tests
  • [x] ICLA (required for bigger changes)

ZuluPro avatar Aug 15 '22 13:08 ZuluPro

Codecov Report

Merging #1743 (a4bdac6) into trunk (26f07ac) will decrease coverage by 0.30%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1743      +/-   ##
==========================================
- Coverage   83.29%   82.98%   -0.31%     
==========================================
  Files         400      350      -50     
  Lines       87770    80789    -6981     
  Branches     9331     8571     -760     
==========================================
- Hits        73104    67044    -6060     
+ Misses      11486    10943     -543     
+ Partials     3180     2802     -378     
Impacted Files Coverage Δ
libcloud/common/dimensiondata.py 94.92% <ø> (ø)
libcloud/common/nttcis.py 73.54% <ø> (ø)
libcloud/compute/base.py 92.83% <ø> (ø)
libcloud/compute/drivers/__init__.py 100.00% <ø> (ø)
libcloud/compute/drivers/opennebula.py 94.28% <ø> (ø)
libcloud/compute/providers.py 87.50% <ø> (ø)
libcloud/compute/types.py 100.00% <ø> (ø)
libcloud/container/providers.py 66.66% <ø> (ø)
libcloud/container/types.py 91.30% <ø> (-0.37%) :arrow_down:
libcloud/dns/providers.py 57.14% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26f07ac...a4bdac6. Read the comment docs.

codecov-commenter avatar Aug 15 '22 14:08 codecov-commenter

@ZuluPro That's for the clean up - it's always good to remove dead / unused code :)

Would appreciate if you could provide some references which document that those providers are not active / alive anymore (I did quickly check some myself and it indeed looks the companies are either dead or pivoted into a different area).

Kami avatar Sep 02 '22 18:09 Kami

I'm trying to sync this up with latest trunk, but it's turning out to be a bit of a pain due to the formatting changes in trunk.

Kami avatar Dec 10 '22 16:12 Kami

@Kami Yes I failed too. I'm really sorry to this branch like this. Let me try to find a solution during the next week.

ZuluPro avatar Dec 12 '22 02:12 ZuluPro

I believe I managed to address all the conflicts in #1852 (but I still need to go over the changes again and double check).

Kami avatar Jan 28 '23 19:01 Kami

#1852 has been merged. Thanks a lot of this clean up!

Kami avatar Jan 29 '23 10:01 Kami