Add a new OVH driver for storage
Add OVH driver for s3 Storage
Description
Add S3 driver for OVHcloud S3 Storage endpoints
Status
- done, ready for review
Checklist (tick everything that applies)
- [x] Code linting (required, can be done after the PR checks)
- [ ] Documentation
- [x] Tests
- [ ] ICLA (required for bigger changes)
@pcqnt Thanks for the contribution - can you please add some unit tests for it (you should be able to inherit a lot of stuff from the existing S3 tests).
Codecov Report
Merging #1732 (2c0b9ce) into trunk (476893f) will increase coverage by
0.00%. The diff coverage is88.63%.
:exclamation: Current head 2c0b9ce differs from pull request most recent head 7a5f979. Consider uploading reports for the commit 7a5f979 to get more accurate results
@@ Coverage Diff @@
## trunk #1732 +/- ##
=======================================
Coverage 83.40% 83.41%
=======================================
Files 392 394 +2
Lines 87636 87680 +44
Branches 10611 10615 +4
=======================================
+ Hits 73096 73135 +39
- Misses 11383 11386 +3
- Partials 3157 3159 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| libcloud/storage/providers.py | 57.14% <ø> (ø) |
|
| libcloud/storage/drivers/ovh.py | 80.00% <80.00%> (ø) |
|
| libcloud/storage/types.py | 100.00% <100.00%> (ø) |
|
| libcloud/test/storage/test_ovh.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 476893f...7a5f979. Read the comment docs.
Thanks for adding some basic unit tests. I've fixed small lint issues and will go ahead and merge the pr into trunk.