libcloud icon indicating copy to clipboard operation
libcloud copied to clipboard
verified publisher icon apache

added new connection type

Open dzaytsev91 opened this issue 3 years ago • 1 comments

Changes Title (replace this with a logical title for your changes)

Description

Added new connection type which support user_id, password and key arguments

Status

ready for review

Checklist (tick everything that applies)

  • [x] Code linting (required, can be done after the PR checks)
  • [x] Documentation
  • [x] Tests
  • [x] ICLA (required for bigger changes)

dzaytsev91 avatar May 09 '22 12:05 dzaytsev91

Thanks for the contribution.

Overall the change looks good to me, but I would be good to see the following:

  1. I would like to understanding the reasoning / context / use case behind this change
  2. Some tests would be good
  3. If applicable, some documentation would also be good.

Kami avatar May 10 '22 22:05 Kami

Closing this PR since it hasn't been updated for a while. If it's still relevant, please re-open it / open a new PR. Thanks!

Kami avatar Dec 10 '22 15:12 Kami