kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #6726] Support trino stage progress

Open taylor12805 opened this issue 1 year ago โ€ข 3 comments

:mag: Description

Issue References ๐Ÿ”—

This pull request fixes https://github.com/apache/kyuubi/issues/6726

Describe Your Solution ๐Ÿ”ง

Add trino statement progress

Types of changes :bookmark:

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan ๐Ÿงช

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests


Checklist ๐Ÿ“

Be nice. Be informative.

taylor12805 avatar Oct 18 '24 10:10 taylor12805

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (2d64255) to head (6646c95). Report is 56 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #6759    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         684     687     +3     
  Lines       42282   42442   +160     
  Branches     5767    5793    +26     
=======================================
- Misses      42282   42442   +160     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


๐Ÿšจ Try these New Features:

codecov-commenter avatar Oct 18 '24 13:10 codecov-commenter

@taylor12805 Before submitting the pull request, we can use ./dev/reformat to format the code.

lsm1 avatar Oct 21 '24 02:10 lsm1

@taylor12805 Before submitting the pull request, we can use ./dev/reformat to format the code.

@lsm1 thanks for reminding. I added test case for trino statement progress, however since trino don't have sleep function, I can't mock multiple stages case. Do you have some ideas?

taylor12805 avatar Oct 21 '24 07:10 taylor12805

@taylor12805* Before submitting the pull request, we can use ./dev/reformat to format the code.

@lsm1* thanks for reminding. I added test case for trino statement progress, however since trino don't have sleep function, I can't mock multiple stages case. Do you have some ideas?

Adding a sleep function in Trino is not straightforward, so simple unit tests should be sufficient for now.

lsm1 avatar Oct 22 '24 09:10 lsm1

@taylor12805 Please fix the failing test

- get operation progress *** FAILED ***
  The code passed to eventually never returned normally. Attempted 1623 times over 25.002736579 seconds. Last failure message: Expected List("Stage-0 ........", "FINISHED", "5", "5", "0", "0", "0", ""), but got Buffer("Stage-0 ........", "FINISHED", "3", "3", "0", "0", "0", ""). (TrinoOperationProgressSuite.scala:43)

lsm1 avatar Nov 19 '24 06:11 lsm1

unfortunately, this patch fails the scala 2.13 CI, @taylor12805 could you please fix that?

pan3793 avatar Nov 22 '24 11:11 pan3793