kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

Bump scala-maven-plugin to 4.9.0

Open bowenliang123 opened this issue 9 months ago โ€ข 2 comments

:mag: Description

Issue References ๐Ÿ”—

This pull request fixes #

Describe Your Solution ๐Ÿ”ง

  • bump scala-maven-plugin from 4.8.0 to 4.9.0, with zinc bumped from 1.8.0(Nov 11, 2022) to 1.9.5(Sep 15, 2023)

Types of changes :bookmark:

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan ๐Ÿงช

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests


Checklist ๐Ÿ“

Be nice. Be informative.

bowenliang123 avatar May 06 '24 06:05 bowenliang123

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (0f6d764) to head (2553f66).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6364   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         677     677           
  Lines       41799   41799           
  Branches     5709    5709           
======================================
  Misses      41799   41799           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 06 '24 07:05 codecov-commenter

Minor warning message thrown in logs, when compilation on Scala 2.13 : Error: -release is only supported on Java 9 and higher (https://github.com/apache/kyuubi/actions/runs/8964924157/job/24623089910#step:8:138)

It's repeatedly shown in logs. It's not a blocker issue though.

bowenliang123 avatar May 08 '24 02:05 bowenliang123

Thanks, merged to master and branch-1.9.

bowenliang123 avatar Jul 30 '24 05:07 bowenliang123

Good to see it land finally

yaooqinn avatar Jul 30 '24 05:07 yaooqinn

Yes, the main concern comes to the benefit with mordernizing the Zinc version. Since last review, the Zinc has been bumped from 1.9.x to 1.10.x used with in the maven plugin. Zinc 1.10 brings the new analysis format for much faster speed in reading and writing, see benchmark in https://github.com/sbt/zinc/pull/1326 . The compilation warning ( https://github.com/apache/kyuubi/pull/6364#issuecomment-2099631757 ) still occurs when compiling on JDK 8 + Scala 2.13, but it's not a blocker issue. And furthermore, let's see whether https://github.com/apache/kyuubi/pull/6571 helps in this case for separating parameter running on JDK 9+ with compiler plugin.

bowenliang123 avatar Jul 30 '24 06:07 bowenliang123