kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #6281][PY] Add lint rules and action lint checks

Open sudohainguyen opened this issue 9 months ago โ€ข 5 comments

:mag: Description

Issue References ๐Ÿ”—

This pull request fixes #6281

Describe Your Solution ๐Ÿ”ง

As part of our efforts to introduce python client built on top of Dropbox's PyHive, I've initialized some linting rules to check with github actions.

Types of changes :bookmark:

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan ๐Ÿงช

Behavior Without This Pull Request :coffin:

Code was following flake8 default format which is not sufficient

Behavior With This Pull Request :tada:

Lint checks now are powered by ruff


Checklist ๐Ÿ“

Be nice. Be informative.

sudohainguyen avatar Apr 27 '24 13:04 sudohainguyen

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.48%. Comparing base (02e1aa3) to head (2e6c3ff).

:exclamation: Current head 2e6c3ff differs from pull request most recent head e3b7598. Consider uploading reports for the commit e3b7598 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6341      +/-   ##
============================================
- Coverage     58.49%   58.48%   -0.02%     
  Complexity       24       24              
============================================
  Files           653      653              
  Lines         39974    39974              
  Branches       5489     5489              
============================================
- Hits          23384    23379       -5     
- Misses        14080    14091      +11     
+ Partials       2510     2504       -6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 27 '24 15:04 codecov-commenter

I'm not sure we should apply new code-style rules at the current stage, I think we should postpone such things at least until the first release is completed. The most urgent thing is setting up CI to run the python test to ensure our ongoing changes won't break the code.

pan3793 avatar Apr 28 '24 01:04 pan3793

sure we can get back to this PR later

however, I'm facing an authentication error installing CDH and trying docker-compose as another approach

sudohainguyen avatar Apr 28 '24 08:04 sudohainguyen

we can use the Apache version for testing.

this project may help you to choose the version combination

pan3793 avatar Apr 28 '24 08:04 pan3793

@pan3793 think we can resume this PR ๐Ÿ˜„

sudohainguyen avatar May 08 '24 01:05 sudohainguyen