kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

kyuubi-beeline auto constructs JDBC URL from kyuubi-defaults.conf

Open zhaohehuhu opened this issue 9 months ago โ€ข 1 comments

:mag: Description

Issue References ๐Ÿ”—

as title This pull request closes #6255

Describe Your Solution ๐Ÿ”ง

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes :bookmark:

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan ๐Ÿงช

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests


Checklist ๐Ÿ“

Be nice. Be informative.

zhaohehuhu avatar Apr 26 '24 07:04 zhaohehuhu

we need the design before implementation.

what's the priority of those configuration files? does our change break the compatibility of vanilla Hive BeeLine? should we merge configurations from different files?

pan3793 avatar Apr 26 '24 09:04 pan3793

Codecov Report

Attention: Patch coverage is 0% with 107 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (315adda) to head (38b36f2).

Files Patch % Lines
...ve/beeline/hs2connection/KyuubiConfFileParser.java 0.00% 87 Missing :warning:
...src/main/java/org/apache/hive/beeline/BeeLine.java 0.00% 12 Missing :warning:
...ne/hs2connection/KyuubiConfFileParseException.java 0.00% 4 Missing :warning:
...ine/hs2connection/UserHS2ConnectionFileParser.java 0.00% 4 Missing :warning:
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6339   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         675     677    +2     
  Lines       41636   41734   +98     
  Branches     5684    5704   +20     
======================================
- Misses      41636   41734   +98     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 10 '24 08:05 codecov-commenter

plz help review again @pan3793 @wForget. Thanks!

zhaohehuhu avatar Jun 04 '24 02:06 zhaohehuhu

thanks for update, will take a look soon

pan3793 avatar Jun 04 '24 02:06 pan3793

thanks for update, will take a look soon

Appreciate it.

zhaohehuhu avatar Jun 04 '24 03:06 zhaohehuhu

@zhaohehuhu before looking into the code, I read and modified kyuubi_beeline.md, almost good, there is still one question on the docs, could you please clarify it?

pan3793 avatar Jun 04 '24 13:06 pan3793

Also cc @wForget, do you think the behavior described in the docs make sense?

pan3793 avatar Jun 04 '24 13:06 pan3793

cc @wForget, I checked the design and docs of Hive BeeLine, and use a similar logic to handle kyuubi-defaults.conf as hive-site.xml, could you please take a look again?

pan3793 avatar Jun 21 '24 07:06 pan3793

Merged to master for 1.10

pan3793 avatar Jun 25 '24 05:06 pan3793

Late LGTM. Sorry I missed these comments.

wForget avatar Jun 26 '24 06:06 wForget