kyuubi
kyuubi copied to clipboard
kyuubi-beeline auto constructs JDBC URL from kyuubi-defaults.conf
:mag: Description
Issue References ๐
as title This pull request closes #6255
Describe Your Solution ๐ง
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Test Plan ๐งช
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests
Checklist ๐
- [x] This patch was not authored or co-authored using Generative Tooling
Be nice. Be informative.
we need the design before implementation.
what's the priority of those configuration files? does our change break the compatibility of vanilla Hive BeeLine? should we merge configurations from different files?
Codecov Report
Attention: Patch coverage is 0%
with 107 lines
in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
315adda
) to head (38b36f2
).
Additional details and impacted files
@@ Coverage Diff @@
## master #6339 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 675 677 +2
Lines 41636 41734 +98
Branches 5684 5704 +20
======================================
- Misses 41636 41734 +98
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
plz help review again @pan3793 @wForget. Thanks!
thanks for update, will take a look soon
thanks for update, will take a look soon
Appreciate it.
@zhaohehuhu before looking into the code, I read and modified kyuubi_beeline.md
, almost good, there is still one question on the docs, could you please clarify it?
Also cc @wForget, do you think the behavior described in the docs make sense?
cc @wForget, I checked the design and docs of Hive BeeLine, and use a similar logic to handle kyuubi-defaults.conf
as hive-site.xml
, could you please take a look again?
Merged to master for 1.10
Late LGTM. Sorry I missed these comments.