kyuubi
kyuubi copied to clipboard
[KYUUBI #6078] KSHC should handle the commit of the partitioned table as dynamic partition at write path
:mag: Description
Issue References ๐
This pull request fixes https://github.com/apache/kyuubi/issues/6078, KSHC should handle the commit of the partitioned table as dynamic partition at write path, that's beacuse the process of writing with Apache Spark DataSourceV2 using dynamic partitioning to handle static partitions.
Describe Your Solution ๐ง
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Test Plan ๐งช
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests
Checklist ๐
- [x] This patch was not authored or co-authored using Generative Tooling
Be nice. Be informative.
Please take a look if you have a time, @FANNG1 @pan3793
Codecov Report
Attention: Patch coverage is 29.82456% with 40 lines in your changes are missing coverage. Please review.
Project coverage is 61.14%. Comparing base (
1adf392) to head (2ae1836). Report is 2 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| ...bi/spark/connector/hive/write/HiveBatchWrite.scala | 21.56% | 39 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #6082 +/- ##
============================================
+ Coverage 61.12% 61.14% +0.02%
Complexity 23 23
============================================
Files 623 623
Lines 37206 37166 -40
Branches 5041 5030 -11
============================================
- Hits 22743 22727 -16
+ Misses 12012 11995 -17
+ Partials 2451 2444 -7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Overall LGTM, let me merge it first, and address comment in follow-up PRs.