kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #6032] Expose KyuubiOperation exec time metrics

Open beryllw opened this issue 1 year ago โ€ข 2 comments

:mag: Description

Issue References ๐Ÿ”—

This pull request fixes #6032

Describe Your Solution ๐Ÿ”ง

KyuubiOperation (LaunchEngine, ExecutedCommandExec) supports exec_time metrics

Types of changes :bookmark:

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan ๐Ÿงช

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests


Checklist ๐Ÿ“

Be nice. Be informative.

beryllw avatar Feb 02 '24 02:02 beryllw

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4bd259a) 61.18% compared to head (af2beb3) 61.07%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6038      +/-   ##
============================================
- Coverage     61.18%   61.07%   -0.11%     
  Complexity       23       23              
============================================
  Files           623      623              
  Lines         37145    37142       -3     
  Branches       5033     5033              
============================================
- Hits          22726    22684      -42     
- Misses        11979    12001      +22     
- Partials       2440     2457      +17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 02 '24 06:02 codecov-commenter

@turboFei @pan3793 cc

beryllw avatar Feb 06 '24 09:02 beryllw