kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #5687] Using session user as proxy user to execute statements at the server and group share level

Open theoryxu opened this issue 2 years ago โ€ข 3 comments

:mag: Description

Issue References ๐Ÿ”—

This pull request fixes #5687

Describe Your Solution ๐Ÿ”ง

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes :bookmark:

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan ๐Ÿงช

Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests


Checklists

๐Ÿ“ Author Self Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] This patch was not authored or co-authored using Generative Tooling

๐Ÿ“ Committer Pre-Merge Checklist

  • [ ] Pull request title is okay.
  • [ ] No license issues.
  • [ ] Milestone correctly set?
  • [ ] Test coverage is ok
  • [ ] Assignees are selected.
  • [ ] Minimum number of approvals
  • [ ] No changes are requested

Be nice. Be informative.

For caution, the parameter set false as the default

theoryxu avatar Nov 24 '23 09:11 theoryxu

@theoryxu it would be nice if you could add a UT for this feature, to demonstrate the behavior differences with this feature enabled/disabled.

pan3793 avatar Nov 27 '23 02:11 pan3793

@theoryxu it would be nice if you could add a UT for this feature, to demonstrate the behavior differences with this feature enabled/disabled.

@pan3793 Thank you for your review.

Iโ€˜ll figure out how Kyuubi's UT framework works and add one for this.

By the way, Are there other flaws I should know about? I could fix it at once.

theoryxu avatar Nov 27 '23 03:11 theoryxu

@theoryxu I'm looking at the implementation in STS, which seems different, I suspect the behaviors are also different.

pan3793 avatar Nov 27 '23 03:11 pan3793