kyuubi
kyuubi copied to clipboard
[Bug] spark submit conf will carry other engine conf
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Search before asking
- [X] I have searched in the issues and found no similar issues.
Describe the bug
spark submit conf will carry other engine conf
Affects Version(s)
master/1.7.1
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?
- [x] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
- [ ] No. I cannot submit a PR at this time.
In [KYUUBI #3875] serverOnly
was introduced to filter out some sensitive configuration propagation, but in practice, only small set of configuration is required for engine, and this issue brings another case, engine-specific configuration, I'm wandering maybe engineRequried
is better
For example:
val ENGINE_TRINO_MEMORY: ConfigEntry[String] =
buildConf("kyuubi.engine.trino.memory")
.doc("The heap memory for the Trino query engine")
.engineRequried("trino")
.version("1.6.0")
.stringConf
.createWithDefault("1g")
cc @lightning-L @turboFei
yes, it is better to exclude the server side config items.
would you like to submit a pr for that?
Yes
how is it going @ASiegeLion ? still occurs in v1.9