kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[WIP] [Authz] initial support for multi-catalog in SparkRangerAdminPlugin

Open bowenliang123 opened this issue 2 years ago • 1 comments

Why are the changes needed?

  • initial support for multi-catalog in SparkRangerAdminPlugin
  • init each RangerBasePlugin for different catalog names
  • falling back to default RangerBasePlugin instance for None or "spark_catalog" catalog
  • use catalog info of AccessResource of AccessRequest to choose RangerBasePlugin instance

How was this patch tested?

  • [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before make a pull request

bowenliang123 avatar Dec 30 '22 14:12 bowenliang123

Codecov Report

Attention: Patch coverage is 76.62338% with 18 lines in your changes missing coverage. Please review.

Project coverage is 53.04%. Comparing base (cd3916d) to head (71c69ce). Report is 1348 commits behind head on master.

Files Patch % Lines
...in/spark/authz/ranger/SparkRangerAdminPlugin.scala 79.03% 2 Missing and 11 partials :warning:
...uubi/plugin/spark/authz/ranger/AccessRequest.scala 50.00% 2 Missing and 1 partial :warning:
...n/spark/authz/ranger/FilteredShowObjectsExec.scala 50.00% 1 Missing :warning:
...k/authz/ranger/RuleReplaceShowObjectCommands.scala 75.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4055      +/-   ##
============================================
- Coverage     53.05%   53.04%   -0.01%     
  Complexity       13       13              
============================================
  Files           547      547              
  Lines         29860    29898      +38     
  Branches       3998     4006       +8     
============================================
+ Hits          15841    15860      +19     
- Misses        12557    12570      +13     
- Partials       1462     1468       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 26 '23 05:12 codecov-commenter