kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #3242] First stop server and then interrupt thread when stopping the frontend service

Open wForget opened this issue 2 years ago • 1 comments

Why are the changes needed?

close #3242

First stop server and then interrupt service thread When stopping Frontend Service, in order to avoid kyuubi server exit hang.

How was this patch tested?

  • [X] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [X] Run test locally before make a pull request

wForget avatar Nov 22 '22 09:11 wForget

Codecov Report

Merging #3830 (3d8a219) into master (a54f214) will decrease coverage by 0.03%. The diff coverage is 92.30%.

@@             Coverage Diff              @@
##             master    #3830      +/-   ##
============================================
- Coverage     52.96%   52.93%   -0.04%     
  Complexity       13       13              
============================================
  Files           497      497              
  Lines         28015    28069      +54     
  Branches       3862     3866       +4     
============================================
+ Hits          14838    14858      +20     
- Misses        11783    11808      +25     
- Partials       1394     1403       +9     
Impacted Files Coverage Δ
...apache/kyuubi/service/TBinaryFrontendService.scala 50.00% <85.71%> (+2.22%) :arrow_up:
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 97.49% <100.00%> (-0.06%) :arrow_down:
...a/org/apache/kyuubi/service/TFrontendService.scala 90.98% <100.00%> (-0.30%) :arrow_down:
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 13.84% <0.00%> (-6.16%) :arrow_down:
...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala 70.65% <0.00%> (-4.95%) :arrow_down:
...apache/kyuubi/session/FileSessionConfAdvisor.scala 89.47% <0.00%> (-4.65%) :arrow_down:
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala 76.84% <0.00%> (-4.22%) :arrow_down:
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala 76.59% <0.00%> (-2.13%) :arrow_down:
...pache/kyuubi/engine/YarnApplicationOperation.scala 62.96% <0.00%> (-1.86%) :arrow_down:
...apache/kyuubi/session/KyuubiBatchSessionImpl.scala 90.66% <0.00%> (-1.23%) :arrow_down:
... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Nov 24 '22 10:11 codecov-commenter